svn commit: r554893 - head/Mk/Scripts

[Bryan Drewery]

On 11/11/2020 5:29 AM, Mathieu Arnold wrote:
> Author: mat
> Date: Wed Nov 11 13:29:52 2020
> New Revision: 554893
> URL: https://svnweb.freebsd.org/changeset/ports/554893
> 
> Log:
>   Add set pipefail in most framework scripts.
>   
>   set pipefail changes the pipeline return status from being the return
>   status of the last command to the last non 0 exit status of any command
>   in the pipeline.  This is needed to make sure all the commands in a
>   pipeline did actually return a non 0 status and not only the last one.
>   
>   PR:		250723
>   Exp-run by:	antoine
>   Reviewed by:	bapt
>   Approved by:	bapt
>   Differential Revision:	https://reviews.freebsd.org/D27007
> 
> Modified:
>   head/Mk/Scripts/check-desktop-entries.sh   (contents, props changed)
>   head/Mk/Scripts/check-stagedir.sh   (contents, props changed)
>   head/Mk/Scripts/check-vulnerable.sh   (contents, props changed)
>   head/Mk/Scripts/check_leftovers.sh   (contents, props changed)
>   head/Mk/Scripts/checksum.sh   (contents, props changed)
>   head/Mk/Scripts/create-manifest.sh   (contents, props changed)
>   head/Mk/Scripts/depends-list.sh   (contents, props changed)
>   head/Mk/Scripts/desktop-categories.sh   (contents, props changed)
>   head/Mk/Scripts/dialog4ports.sh   (contents, props changed)
>   head/Mk/Scripts/do-depends.sh   (contents, props changed)
>   head/Mk/Scripts/do-fetch.sh   (contents, props changed)
>   head/Mk/Scripts/do-patch.sh   (contents, props changed)
>   head/Mk/Scripts/do-users-groups.sh   (contents, props changed)
>   head/Mk/Scripts/find-lib.sh   (contents, props changed)
>   head/Mk/Scripts/generate-symbols.sh   (contents, props changed)
>   head/Mk/Scripts/install-desktop-entries.sh   (contents, props changed)
>   head/Mk/Scripts/makesum.sh   (contents, props changed)
>   head/Mk/Scripts/plist_sub_sed_sort.sh   (contents, props changed)
>   head/Mk/Scripts/ports_env.sh   (contents, props changed)
>   head/Mk/Scripts/qa.sh   (contents, props changed)
>   head/Mk/Scripts/rust-compat11-canary.sh   (contents, props changed)
>   head/Mk/Scripts/smart_makepatch.sh   (contents, props changed)
> 
> Modified: head/Mk/Scripts/check-desktop-entries.sh
> ==============================================================================
> --- head/Mk/Scripts/check-desktop-entries.sh	Wed Nov 11 13:24:31 2020	(r554892)
> +++ head/Mk/Scripts/check-desktop-entries.sh	Wed Nov 11 13:29:52 2020	(r554893)
> @@ -4,6 +4,7 @@
>  # MAINTAINER: portmgr at FreeBSD.org
>  
>  set -e
> +set -o pipefail
>  
>  . "${dp_SCRIPTSDIR}/functions.sh"
>  
> 

This can prevent someone from upgrading from an unsupported release. The
workaround is simple enough so I think we should take it rather than
create burdens for people.

    command set -o pipefail 2>/dev/null || :

-- 
Regards,
Bryan Drewery
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20201119/bc635359/attachment.sig>