svn commit: r554143 - head/devel/git

[Guido Falsi]

On 05/11/20 18:04, Renato Botelho wrote:
> Author: garga
> Date: Thu Nov  5 17:04:19 2020
> New Revision: 554143
> URL: https://svnweb.freebsd.org/changeset/ports/554143
> 
> Log:
>    devel/git: Update to 2.29.2 and small tweaks
>    
>    - Update to 2.29.2 [1]
>    - Simplify logic to define COMMENT for each flavor
>    - Inspired in www/py-autobahn, save OPTIONS on a different file for each flavor
>    
>    PR:		250472 [1]
>    Submitted by:	Yasuhiro KIMURA <yasu at utahime.org> [1]
>    Sponsored by:	Rubicon Communications, LLC (Netgate)
> 
> Modified:
>    head/devel/git/Makefile
>    head/devel/git/distinfo
>    head/devel/git/pkg-plist
> 
> Modified: head/devel/git/Makefile
> ==============================================================================
> --- head/devel/git/Makefile	Thu Nov  5 16:51:30 2020	(r554142)
> +++ head/devel/git/Makefile	Thu Nov  5 17:04:19 2020	(r554143)
> @@ -2,7 +2,7 @@
>   # $FreeBSD$
[...]
> @@ -76,6 +73,8 @@ OPTIONS_EXCLUDE=	GUI SVN GITWEB CONTRIB P4 CVS PERL
>   .endif
>   
>   OPTIONS_SUB=	yes
> +
> +OPTIONS_FILE=		${PORT_DBDIR}/${OPTIONS_NAME}/${FLAVOR}-options

I'm not sure why, but this is not working as expected IMHO.

I noticed that, when using "poudriere options" and building with 
"poudriere bulk" the options file is ignored. poudsriere option 
continuously brings up the git dialog4ports screen and asks options 
proposing the defaults. The option file is correctly written but never 
read. poudriere bulk ignores it and builds with default options.

Also on the local machine running make config repeatedly in the port 
directory does the same: the dialog4ports sscreen comes up with default 
options each time and the options file is written but never read.

Am I missing something? is something special required for this to 
actually work?

-- 
Guido Falsi <madpilot at FreeBSD.org>