svn commit: r528542 - head/Mk/Uses

[Mathieu Arnold]

On Tue, Mar 17, 2020 at 10:58:50AM +0400, Gleb Popov wrote:
> On Tue, Mar 17, 2020 at 12:06 AM Mathieu Arnold <mat at freebsd.org> wrote:
> 
> > On Mon, Mar 16, 2020 at 07:59:27PM +0000, Gleb Popov wrote:
> > > Author: arrowd
> > > Date: Mon Mar 16 19:59:27 2020
> > > New Revision: 528542
> > > URL: https://svnweb.freebsd.org/changeset/ports/528542
> > >
> > > Log:
> > >   Mk/Uses/cabal.mk: Wrap *.cabal argument in ticks.
> >
> > Why?
> >
> 
> This fixed build for port I was working on. I don't have a reproducer
> anymore.
> 
> Is this change bad?

I have no idea about the change.  What was bad is the commit message.  A
commit message is where you record for the history WHY something was
done, so that when someone looks at it later, they can understand why it
was done.
A commit message cannot be the diff translated to english, because it
does not explain why the change was made, why it was necessary, what it
was fixing.

> 
> > > Modified:
> > >   head/Mk/Uses/cabal.mk
> > >
> > > Modified: head/Mk/Uses/cabal.mk
> > >
> > ==============================================================================
> > > --- head/Mk/Uses/cabal.mk     Mon Mar 16 19:57:41 2020        (r528541)
> > > +++ head/Mk/Uses/cabal.mk     Mon Mar 16 19:59:27 2020        (r528542)
> > > @@ -141,7 +141,7 @@ make-use-cabal-revs:
> > >  cabal-post-extract:
> > >  .    for package in ${_use_cabal}
> > >  .      if ${package:C/[^_]*//:S/_//} != ""
> > > -             cp
> > ${DISTDIR}/${DIST_SUBDIR}/${package:C/_[0-9]+//}/revision/${package:C/[^_]*//:S/_//}.cabal
> > `find ${WRKDIR}/${package:C/_[0-9]+//} -name *.cabal -depth 1`
> > > +             cp
> > ${DISTDIR}/${DIST_SUBDIR}/${package:C/_[0-9]+//}/revision/${package:C/[^_]*//:S/_//}.cabal
> > `find ${WRKDIR}/${package:C/_[0-9]+//} -name '*.cabal' -depth 1`
> > >  .      endif
> > >       cd ${WRKDIR} && \
> > >               mv ${package:C/_[0-9]+//} ${WRKSRC}/
> > >
> >
> > --
> > Mathieu Arnold
> >

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20200317/3b3745cc/attachment.sig>