svn commit: r528249 - in head/emulators: i386-wine-devel wine-devel

[Lorenzo Salvadore]

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Friday 13 March 2020 00:00, Gerald Pfeifer <gerald at pfeifer.com> wrote:

> On Thu, 12 Mar 2020, Lorenzo Salvadore wrote:
>
> > On Thursday 12 March 2020 02:45, Alexey Dokuchaev danfe at freebsd.org wrote:
> > Looks like this file should've been repocopied, but it wasn't. :-(
> > Maybe it's my fault: I am still new as a committer and I might have done
> > the renaming in the wrong way. I used "svn mv".
> > Any idea how could I have done it better?
>
> `svn mv`, as you and me had discussed, is the right way, cf.
> https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/article.html#svn-daily-use-copying-and-moving
>
> (`svn mv` is a shortcut for `svn move`, so that is not material.)
>
> Could it be that, in the tree you did the commit from, you ran a
> regular `mv` instead of `svn mv`?

I am 99% sure that I did use svn mv.

> PS: Having just scanned the SVN Primer of our Committers Guide again, I
> believe we should recommend running `svn status` in addition to `svn diff`
> before every commit. The former shows file moves quite nicely. If you
> don't beat me to it, I'll open a PR in the coming days...

I doubt I will beat you: I have too many things to do, feel free to open the PR.

Thanks!
Lorenzo Salvadore