svn commit: r528101 - head/www/chromium/files

[Joseph Mingrone]

Joseph Mingrone <jrm at FreeBSD.org> writes:

> Christoph Moench-Tegeder <cmt at FreeBSD.org> writes:

>> Author: cmt
>> Date: Mon Mar  9 10:25:45 2020
>> New Revision: 528101
>> URL: https://svnweb.freebsd.org/changeset/ports/528101

>> Log:
>>   remove patches obviously forgotten when updating to chrome 80

>>   these patches don't apply anymore and are not needed anymore, according
>>   to my reading of the code

>>   PR:		244625
>>   Approved by:	"trivial build fixes" blanket

>> Deleted:
>>   head/www/chromium/files/patch-base_memory_protected__memory__posix.cc
>>   head/www/chromium/files/patch-chrome_browser_browser__features.cc
>>   head/www/chromium/files/patch-chrome_browser_browser__features.h
>>   head/www/chromium/files/patch-chrome_browser_platform__util.h
>>   head/www/chromium/files/patch-content_public_app_v8__snapshot__overlay__manifest.cc
>>   head/www/chromium/files/patch-content_renderer_media_webrtc_webrtc__audio__renderer__unittest.cc
>>   head/www/chromium/files/patch-media_gpu_libyuv__image__processor.cc
>>   head/www/chromium/files/patch-remoting_webapp_base_js_platform.js
>>   head/www/chromium/files/patch-services_device_time__zone__monitor_time__zone__monitor.cc
>>   head/www/chromium/files/patch-ui_gl_gl__surface__glx.cc
>>   head/www/chromium/files/patch-ui_platform__window_platform__window__delegate.h
>>   head/www/chromium/files/patch-v8_src_trap-handler_handler-inside-posix.cc
>>   head/www/chromium/files/patch-v8_src_trap-handler_handler-inside-posix.h
>>   head/www/chromium/files/patch-v8_src_trap-handler_trap-handler.h

> I do now see that r528072/528087 fail at the patch stage, but I'm not
> exactly clear how the problem crept in [1].

> In any case, thanks for fixing.

> [1] `arc patch D23984` and poudriere testport` didn't show any problems.
> It seems you can't `arc patch` after the revision is closed, but I
> downloaded the patch then reverted and patched my ports tree and hit the
> problem.  I'm out of time now, but I'll try to solve the mystery later.

I don't see anything in Phabricator's web interface, but by messing with
the URLs from the Phabricator emails, one can see older versions [1] of
Phabricator Differentials by supplying ?id=xxx.

https://reviews.freebsd.org/D23984?id=69293 shows that the patch files
above were deleted in the review, but the differential gets updated with
what was committed.  This caused me some confusion, so I thought it
might be useful to share.

[1] Unsure if Phabricator has a standard term for this
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 987 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20200310/0cf2a3c4/attachment.sig>