svn commit: r540489 - in head/devel/fhist: . files

[Mathieu Arnold]

On Fri, Jun 26, 2020 at 08:11:36AM -0700, Cy Schubert wrote:
> In message <20200626132841.kytmjwquonpwkrhr at aching.in.mat.cc>, Mathieu 
> Arnold w
> rites:
> > 
> > --fq3my2lrxbkpfplh
> > Content-Type: text/plain; charset=us-ascii
> > Content-Disposition: inline
> > Content-Transfer-Encoding: quoted-printable
> >
> > On Fri, Jun 26, 2020 at 12:41:05PM +0000, Alexey Dokuchaev wrote:
> > > On Fri, Jun 26, 2020 at 10:34:36AM +0000, Fernando Apestegu??a wrote:
> > > > New Revision: 540489
> > > > URL: https://svnweb.freebsd.org/changeset/ports/540489
> > > >=20
> > > > Log:
> > > >   devel/fhist: and fix bison issues and change maintership
> > > >=20
> > > > Modified:
> > > >   head/devel/fhist/Makefile
> > > >   head/devel/fhist/files/patch-common_ac_time.h
> > > >=20
> > > > Modified: head/devel/fhist/files/patch-common_ac_time.h
> > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> > =3D=3D=3D=3D=3D
> > > > --- head/devel/fhist/files/patch-common_ac_time.h	Fri Jun 26 09:35:06 2=
> > 020	(r540488)
> > > > +++ head/devel/fhist/files/patch-common_ac_time.h	Fri Jun 26 10:34:36 2=
> > 020	(r540489)
> > > > @@ -1,6 +1,6 @@
> > > > ---- common/ac/time.h.orig	Wed Dec 18 02:09:57 2002
> > > > -+++ common/ac/time.h	Wed Dec 18 02:10:04 2002
> > > > -@@ -29,7 +29,7 @@
> > > > +--- common/ac/time.h.orig	2012-07-13 04:47:15 UTC
> > > > ++++ common/ac/time.h
> > > > +@@ -26,7 +26,7 @@
> > > >    * Catch-22: Dec Alpha OSF/1: need to include time.h before sys/time.h
> > > >    * before time.h
> > > >    */
> > >=20
> > > Please, "svn revert" patches which forwent no functional changes prior
> > > to making commit.  It just clutters the diff and decreases SNR. :-(
> >
> > In that particular case, it was correct to commit the patch, it has
> > functional change, the range information changed, and it is definitively
> > not just noise.
> 
> I see no problem regenerating patches. I do have a problem with cosmetic 
> changes intermixed with functional changes like fix X and portlint, or fix 
> X and regenerate patches. Keep them separate. They're easier for people 
> reading the logs to parse weeks or months from now.

This change was absolutely not cosmetic, it updated the patch files to
match with the current sources from the port.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20200629/e130f075/attachment.sig>