svn commit: r539531 - in head/security: . vigenere

[Fernando Apesteguía]

On Fri, Jun 19, 2020 at 8:49 AM Adam Weinberger <adamw at adamw.org> wrote:
>
> On Thu, Jun 18, 2020 at 12:57 AM Fernando Apesteguía
> <fernape at freebsd.org> wrote:
> >
> > Author: fernape
> > Date: Thu Jun 18 06:57:44 2020
> > New Revision: 539531
> > URL: https://svnweb.freebsd.org/changeset/ports/539531
> >
> > Log:
> >   new port: security/vigenere: cipher algorithm tool
> >
> >   vigenere is an implementation of the Vigenere cipher algorithm extended
> >   to the entire set of printable ASCII characters
> >
> >   https://www.olivermahmoudi.com/programming/vigenere-cipher/
> >
> >   PR:   247244
> >   Submitted by: fbsd at olivermahmoudi.com
> >
> > Added:
> >   head/security/vigenere/
> >   head/security/vigenere/Makefile   (contents, props changed)
> >   head/security/vigenere/distinfo   (contents, props changed)
> >   head/security/vigenere/pkg-descr   (contents, props changed)
> > Modified:
> >   head/security/Makefile
> >
> > Modified: head/security/Makefile
> > ==============================================================================
> > --- head/security/Makefile      Thu Jun 18 06:57:40 2020        (r539530)
> > +++ head/security/Makefile      Thu Jun 18 06:57:44 2020        (r539531)
> > @@ -1259,6 +1259,7 @@
> >      SUBDIR += vanguards-tor
> >      SUBDIR += vault
> >      SUBDIR += veracrypt
> > +    SUBDIR += vigenere
> >      SUBDIR += vinetto
> >      SUBDIR += vlock
> >      SUBDIR += vm-to-tor
> >
> > Added: head/security/vigenere/Makefile
> > ==============================================================================
> > --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> > +++ head/security/vigenere/Makefile     Thu Jun 18 06:57:44 2020        (r539531)
> > @@ -0,0 +1,24 @@
> > +# $FreeBSD$
> > +
> > +PORTNAME=      vigenere
> > +PORTVERSION=   1.0
> > +CATEGORIES=    security
> > +MASTER_SITES=  http://www.olivermahmoudi.com/files/
> > +
> > +MAINTAINER=    fbsd at olivermahmoudi.com
> > +COMMENT=       Vigenere cipher cryptography tool
> > +
> > +LICENSE=       BSD2CLAUSE
> > +LICENSE_FILE=  ${WRKSRC}/LICENSE
> > +
> > +PLIST_FILES=   bin/vigenere \
> > +               man/man1/vigenere.1.gz
> > +
> > +do-build:
> > +       cd ${WRKSRC} && ${CC} ${CFLAGS} ${LDFLAGS} -o ${PORTNAME} ${PORTNAME}.c
> > +
> > +do-install:
> > +       ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${STAGEDIR}${PREFIX}/bin
> > +       ${INSTALL_MAN} ${WRKSRC}/${PORTNAME}.1 ${STAGEDIR}${PREFIX}/man/man1
> > +
> > +.include <bsd.port.mk>
> >
> > Added: head/security/vigenere/distinfo
> > ==============================================================================
> > --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> > +++ head/security/vigenere/distinfo     Thu Jun 18 06:57:44 2020        (r539531)
> > @@ -0,0 +1,3 @@
> > +TIMESTAMP = 1592095290
> > +SHA256 (vigenere-1.0.tar.gz) = 96bc7dc9b582a36ec020cee47f9840065b7beb53ef8d5b68962643077b6c0b6b
> > +SIZE (vigenere-1.0.tar.gz) = 5618
> >
> > Added: head/security/vigenere/pkg-descr
> > ==============================================================================
> > --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> > +++ head/security/vigenere/pkg-descr    Thu Jun 18 06:57:44 2020        (r539531)
> > @@ -0,0 +1,6 @@
> > +vigenere is an implementation of the Vigenere cipher encryption
> > +algorithm with an extension to all printable ASCII characters.
> > +The utility is capable of encrypting/decrypting arguments that
> > +are passed to it upon invocation or process input- and outputfiles.
> > +
> > +WWW: https://www.olivermahmoudi.com/programming/vigenere-cipher/
>
> Hi Fernando,
>
> That WWW is 404, and there's no mention of the software on Oliver's website.

Hi Adam!

I'm pretty sure I checked that, but maybe I missed it?. I will open a
PR asking him about it.

>
> Is this cipher actively used for modern practical purposes? If not,
> this sounds like a programming exercise and I'm not sure why it'd need
> a port.

Before including the new port I checked Oliver was the maintainer of
other ports, some of which I had incidentally committed to recently
(sysutils/mapdir).
Some of his ports include security/caesarcipher that I assume nobody
uses for modern practical purposes either :-) It also happens he is
the original writer of the four ports he maintains.

I read the Committers Guide about new ports
(https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/article.html#ports-qa-adding)
in search of policy but couldn't find any.

Should submitters "make a case" for the new port to be included?
Should the committer refuse if he/she evaluates the software is not
useful enough?

Cheers.
>
> # Adam
>
>
> --
> Adam Weinberger
> adamw at adamw.org
> https://www.adamw.org