svn commit: r522273 - in head/sysutils/lsof: . files

[Mathieu Arnold]

On Mon, Jan 06, 2020 at 02:19:58PM -0700, Adam Weinberger wrote:
> On Mon, Jan 6, 2020 at 2:05 PM Larry Rosenman <ler at freebsd.org> wrote:
> >
> > On 01/06/2020 3:02 pm, Cy Schubert wrote:
> > > In message <202001062042.006Kg81F048249 at repo.freebsd.org>, Larry
> > > Rosenman
> > > write
> > > s:
> > >> Author: ler
> > >> Date: Mon Jan  6 20:42:08 2020
> > >> New Revision: 522273
> > >> URL: https://svnweb.freebsd.org/changeset/ports/522273
> > >>
> > >> Log:
> > >>   sysutils/lsof: fix build following base r356337.
> > >>
> > >>   I took the patch from 243122 as it was more correct.
> > >>
> > >>   PR:                243122, 243083
> > >>   Submitted by:      cy, yasu at utahime.org
> > >>
> > >> Added:
> > >>   head/sysutils/lsof/files/patch-dialects_freebsd_dnode2.c
> > >> (contents, props
> > >>  changed)
> > >> Modified:
> > >>   head/sysutils/lsof/Makefile
> > >>
> > >> Modified: head/sysutils/lsof/Makefile
> > >> =============================================================================
> > >> =
> > >> --- head/sysutils/lsof/Makefile      Mon Jan  6 20:25:36 2020        (r52227
> > >> 2)
> > >> +++ head/sysutils/lsof/Makefile      Mon Jan  6 20:42:08 2020        (r52227
> > >> 3)
> > >> @@ -3,7 +3,7 @@
> > >>
> > >>  PORTNAME=   lsof
> > >>  DISTVERSION=        4.93.2
> > >> -PORTREVISION=       6
> > >> +PORTREVISION=       8
> > >
> > > Was this needed? The package doesn't change, only fixing the build.
> > >
> > >>  PORTEPOCH=  8
> > >>  CATEGORIES= sysutils
> > >>
> > >>
> >
> > I thought build breaks on the cluster needed a port rev bump...
> 
> The logic is that if the currently-built package needs to change, it
> requires a bump. If there is no currently-built package because of a
> build failure, a bump doesn't have a meaningful effect.

Said in another way, PORTREVISION bumps happen when an existing package,
4.93.2_6 here, has issues (mostly runtime, but can be other reasons, see
the PHB for full list) and it needs to be upgraded to a newer version to
work correctly, 4.93.2_8 here.

If 4.93.2_6 never existed because it could not be built, well, the most
anybody ever had was 4.93.2_5, and once 4.93.2_6 finally builds, it will
get updated correctly.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20200106/a1e033ae/attachment.sig>