svn commit: r521892 - in head/math: . R-cran-alabama

[Mathieu Arnold]

On Fri, Jan 03, 2020 at 03:50:06PM +0100, Adriaan de Groot wrote:
> On Friday, 3 January 2020 09:36:28 CET Mathieu Arnold wrote:
> > On Fri, Jan 03, 2020 at 12:56:48AM +0000, Devin Teske wrote:
> > > Author: dteske (src committer)
> > 
> > As stated by this ^^^^^^^^^^^^^ you are not a ports committer.  So you
> > are required to get approval, and state the approval in your commits,
> > saying it has been reviewed is not enough.
> > 
> > >   Reviewed by:	mat, imp (previous revision)
> > >   Differential Revision:	https://reviews.freebsd.org/D22675
> 
> Question for mat@, just to be clear: the issue here is (only) that there 
> should be an extra line in the commit message,
> 	Approved by: mat
> or possibly
> 	Approved by: mat (mentor)
> as described in the committer's guide [1].

Yes, it was missing the approved by line. (Without the mentor part,
dteske is not a ports committer.)

> The Phab review was approved (accepted), so it's just the documentation of 
> process? 
> 
> 
> [1] https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/
> commit-log-message.html
> 
> 
> [ade]



-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20200103/aba46f37/attachment.sig>