svn commit: r525704 - head/math/hmat-oss

[Piotr Kubaj]

The only supported FreeBSD version that doesn't support OpenMP is 12.0 with Clang and it's soon going EOL.

This means that all supported releases will soon have OpenMP supported by base compiler (either by GCC or Clang) and USES=compiler:openmp may then be removed. All occurences of: .if ${CHOSEN_COMPILER_TYPE} == gcc USE_GCC=yes should then be converted to just USES=compiler:c11.

So IMO there's little point in your change now that 12.0 EOL is in over 2 weeks.

On 20-02-12 01:01:25, Gerald Pfeifer wrote:
> [ adding powerpc@ ]
> 
> On Mon, 10 Feb 2020, Piotr Kubaj wrote:
> > Log:
> >   math/hmat-oss: fix build on GCC architectures
> >   
> >   After OpenBLAS update, new GCC is required:
> >   CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
> >     Could NOT find CBLAS (missing: CBLAS_LIBRARIES)
> :
> > +.if ${CHOSEN_COMPILER_TYPE} == gcc
> > +USE_GCC=	yes
> > +.endif
> 
> This made me realize something bizarre:  Mk/Uses/compiler.mk has
> 
>    .if ${_COMPILER_ARGS:Mopenmp}
>    .if ${COMPILER_TYPE} == clang  
>    USE_GCC=        yes
>    CHOSEN_COMPILER_TYPE=   gcc
>    .endif
>    .endif
> 
> If I read this correctly, on platforms with GCC as the system compiler 
> this means the rotten GCC 4.2 is used for something new and evolving 
> like OpenMP?
> 
> Really, OpenMP should imply USE_GCC=yes instead of even trying to
> rely on GCC 4.2.  That would save you the effort of having to make 
> such changes one by one and also simplify the ports tree.
> 
> *And* it would align powerpc* more closely with i386/amd64 by using
> the same compiler for such ports.
> 
> I'll be happy to prepare a patch for Mk/Uses/compiler.mk, but we'd
> need you (and/or other powerpc* folks) to give it a try and adjust
> things if necessary.  Would you like to?
> 
> Gerald
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20200212/9a7dbddd/attachment.sig>