svn commit: r525035 - in head/print: . xreader
Alexey Dokuchaev
danfe at freebsd.org
Tue Feb 4 05:23:30 UTC 2020
On Mon, Feb 03, 2020 at 02:41:16PM -0500, Steve Wills wrote:
> On 2/3/20 8:22 AM, Alexey Dokuchaev wrote:
> > New Revision: 525035
> > URL: https://svnweb.freebsd.org/changeset/ports/525035
> >
> > [...]
Please don't overquote. :-)
> > +post-patch:
> > + @${REINPLACE_CMD} -e '/gdk\/gdkwayland\.h/d' \
> > + ${WRKSRC}/libdocument/ev-document-misc.h
> > +
>
> This REINPLACE_CMD doesn't seem necessary, it seems to build fine for me
> without this.
It is needed, Steve: this header file is guarded by %%WAYLAND%% if you
look inside `x11-toolkits/gtk30/pkg-plist', and many people disable this
option. The header seems to be unused anyways, so I've just removed it
unconditionally.
> -USES= desktop-file-utils gettext-tools gnome meson pkgconfig
> +USES= desktop-file-utils gettext-tools gnome meson pkgconfig xorg
Indeed, I've missed this bit.
> -MESON_ARGS= -Depub=false -Dtests=false
> +MESON_ARGS= -Depub=false \
> + -Dtests=false
This part is different now after r525048, but I don't see what's wrong with
putting two short words on the same line: it does not sacrifice readability
and makes Makefile a little shorter and thus easier to nagivate.
> [ Gratuitous whitespace shuffling omitted ]
I spend quite a lot of time on making sure my ports are well formatted,
readable, easy to work with, and overall neat. The amount of whitespace
is carefully calculated and correct as it is.
./danfe
More information about the svn-ports-all
mailing list