svn commit: r557697 - in head/shells: . anongitssh

[Adam Weinberger]

On Thu, Dec 10, 2020 at 9:10 PM Li-Wen Hsu <lwhsu at freebsd.org> wrote:
>
> Author: lwhsu
> Date: Fri Dec 11 04:10:38 2020
> New Revision: 557697
> URL: https://svnweb.freebsd.org/changeset/ports/557697
>
> Log:
>   Add shells/anongitssh: Restricted shell for git-upload-pack over SSH
>
>   Note: The default setting is for git.FreeBSD.org only and needs to be
>         overridden and rebuilt for being useful in other setups.
>
>   Support of config file and other improvements will be available in
>   the upcoming updates.
>
>   Discussed with: hrs
>   Sponsored by: The FreeBSD Foundation
>
> Added: head/shells/anongitssh/Makefile
> ==============================================================================
> +GITUPLOADPACK_PATH?=   /usr/local/bin/git-upload-pack

Is this a local path or a path on the remote server? If local, this
should be using ${LOCALBASE} instead of hardcoding /usr/local.

> +OPTIONS_DEFINE=        DOCS
> +OPTIONS_DEFAULT=DOCS

DOCS is automatically in OPTIONS_DEFAULT.

> +pre-install-DOCS-on:
> +       @${MKDIR} ${STAGEDIR}${DOCSDIR}
> +
> +post-install-DOCS-on:
> +       ${INSTALL_DATA} ${WRKSRC}/README ${STAGEDIR}${DOCSDIR}

There's no need for a separate pre-install target. These can be
combined into the post-install-DOCS-on target.

> Added: head/shells/anongitssh/pkg-message
> ==============================================================================
> --- /dev/null   00:00:00 1970   (empty, because file is newly added)
> +++ head/shells/anongitssh/pkg-message  Fri Dec 11 04:10:38 2020        (r557697)
> @@ -0,0 +1,2 @@
> +The default setting is for git.FreeBSD.org only and needs to be
> +overridden and rebuilt for being useful in other setups.

pkg-message in UCL is highly preferred, as this message is only
relevant on initial installation and not upgrades. See
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/pkg-files.html#porting-message

# Adam


-- 
Adam Weinberger
adamw at adamw.org
https://www.adamw.org