svn commit: r545609 - in head/devel/gcc-msp430-ti-toolchain: . files

[Mathieu Arnold]

On Fri, Aug 21, 2020 at 03:51:25PM +0000, Lev A. Serebryakov wrote:
> +# Strip binaries
> +.if !defined(DEBUG)
> +	@for bin in $$(${FIND} ${INTERIM_PREFIX}/bin -type f -name ${TARGET}-\*) ; do \
> +		if ! ${FILE} $$bin | ${GREP} -qs ': ELF' ; then continue ; fi ; \
> +		${STRIP_CMD} $${bin} ; \
> +	done

Is there a particular reason for doing things in a way that convoluted?

I mean, is there a reason for not doing it in a straight way like this:

	@for bin in $$(${FIND} ${INTERIM_PREFIX}/bin -type f -name ${TARGET}-\*) ; do \
		if ${FILE} $$bin | ${GREP} -qs ': ELF' ; then  \
			${STRIP_CMD} $${bin} ; \
		fi ; \
	done

We usually write `if something I want; then somethig; fi`.
The `if something I don't want; then continue; fi; something` is reather
strange.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20200824/c4eb6ba4/attachment.sig>