svn commit: r544245 - head/x11/sakura

[Alexey Dokuchaev]

On Thu, Aug 06, 2020 at 11:46:26AM +0100, Danilo Eg??a Gondolfo wrote:
> On Thu, Aug 6, 2020 at 4:34 AM Alexey Dokuchaev <danfe at freebsd.org> wrote:
> 
> > On Wed, Aug 05, 2020 at 09:55:48PM +0000, Danilo Egea Gondolfo wrote:
> > > New Revision: 544245
> > > URL: https://svnweb.freebsd.org/changeset/ports/544245
> > >
> > > @@ -14,9 +14,10 @@ LICENSE=   GPLv2
> > >  LIB_DEPENDS= libgnutls.so:security/gnutls \
> > >               libpcre2-8.so:devel/pcre2
> > >
> > > +USES=                cmake gnome pkgconfig gettext perl5 tar:bz2 xorg
> > > +
> > >  OPTIONS_DEFINE=      DOCS
> > >
> > > -USES=                cmake gnome pkgconfig gettext perl5 xorg
> > >  USE_GNOME=   cairo gdkpixbuf2 vte3
> > >  USE_XORG=    x11
> > >  USE_PERL5=   build
> >
> > I'd argue that USES was placed better before this change (right next to
> > USE_FOO knobs).  It should've been left where it was and OPTIONS_DEFINE
> > moved downwards instead.
> 
> Just tried to make portlint happy on this one ("USES should appear
> earlier").

I know why you did this, but it does not make the change less wrong.

./danfe