svn commit: r544245 - head/x11/sakura

Mateusz Piotrowski 0mp at FreeBSD.org
Thu Aug 6 11:50:04 UTC 2020


On 8/6/20 12:46 PM, Danilo Egêa Gondolfo wrote:
> On Thu, Aug 6, 2020 at 4:34 AM Alexey Dokuchaev <danfe at freebsd.org> wrote:
>
>> On Wed, Aug 05, 2020 at 09:55:48PM +0000, Danilo Egea Gondolfo wrote:
>>> New Revision: 544245
>>> URL: https://svnweb.freebsd.org/changeset/ports/544245
>>>
>>> @@ -14,9 +14,10 @@ LICENSE=   GPLv2
>>>   LIB_DEPENDS= libgnutls.so:security/gnutls \
>>>                libpcre2-8.so:devel/pcre2
>>>
>>> +USES=                cmake gnome pkgconfig gettext perl5 tar:bz2 xorg
>>> +
>>>   OPTIONS_DEFINE=      DOCS
>>>
>>> -USES=                cmake gnome pkgconfig gettext perl5 xorg
>>>   USE_GNOME=   cairo gdkpixbuf2 vte3
>> I'd argue that USES was placed better before this change (right next to
>> USE_FOO knobs).  It should've been left where it was and OPTIONS_DEFINE
>> moved downwards instead.
>>
>> ./danfe
>>
> Just tried to make portlint happy on this one ("USES should appear
> earlier").

Please try portfmt and portclippy from ports-mgmt/portfmt. They are much better for order fixes and 
simple style fixes than portlint in most cases.

Cheers,

Mateusz Piotrowski



More information about the svn-ports-all mailing list