svn commit: r532950 - in head/lang/gcc9: . files

Gerald Pfeifer gerald at pfeifer.com
Sat Apr 25 15:44:10 UTC 2020


On Sat, 25 Apr 2020, Piotr Kubaj wrote:
>   PR:		245511, 242506
>   Approved by:	gerald (maintainer timeout)

Please avoid commit logs with overly long lines (like 299 characters).

And I recommend running `portlint -C` to catch simple issues.


Some of your changes look like the result of random poking, which made
them painful to review and follow.  I reopened PR 245511 and provided 
what might be a simpler way¹ to achieve the same outcome (which still
is far from ideal -- building GCC with -O0 definitely is not -- but
tackling that can be another step).

Gerald

¹ Variable assignments in form of command-line options of the make 
  command have higher priority than those in the environment.


More information about the svn-ports-all mailing list