svn commit: r531475 - in head/dns/dnsmasq: . files

[Rene Ladan]

On Sun, Apr 12, 2020 at 02:16:10AM +0000, Matthias Andree wrote:
> Author: mandree
> Date: Sun Apr 12 02:16:10 2020
> New Revision: 531475
> URL: https://svnweb.freebsd.org/changeset/ports/531475
> 
> Log:
>   dns/dnsmasq: repair damage from UNAUTHORIZED UCL conversion of pkg-message
>   
>   The pkg-message contains a security note that is necessary on
>   new installs and on updates alike.
>   
>   Since per the porter's handbook, the UCL does not support enumeration
>   of types, and this is not relevant on removal, the UCL change must be
>   reverted.  While here, remove formatting.
>   
>   Failure inducing commit:
>   |------------------------------------------------------------------------
>   |r508835 | mat | 2019-08-13 18:01:59 +0200 (Tue, 13 Aug 2019) | 2 lines
>   |
>   |Convert to UCL & cleanup pkg-message (categories d)
>   |
>   |------------------------------------------------------------------------
>   
>   NOTE: The UCL conversion of files/pkg-message.in was not authorized
>   and damaging and no heads-up was sent to the maintainer.
>   
>   portmgr@ MUST act more carefully with sweeping changes and hand them out
>   for review first.
> 
You are clearly missing the bigger picture here, which is to only show users
messages from pkg when they are needed.  pkg-message *does* support showing
messages on both install and update (see section 9.1.1 of
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/pkg-files.html )

This page also notes: "Committers have blanket approval to constrain existing
messages to install or upgrade ranges using the UCL format specifications."

Please revert and fix properly.

René