svn commit: r530850 - head/sysutils/duplicity

[Adam Weinberger]

On Sun, Apr 5, 2020 at 6:28 PM Danilo G. Baio <dbaio at freebsd.org> wrote:
>
> Author: dbaio
> Date: Mon Apr  6 00:27:15 2020
> New Revision: 530850
> URL: https://svnweb.freebsd.org/changeset/ports/530850
>
> Log:
>   sysutils/duplicity: Fix build when NLS option is off
>
>   Reported by:  filis
>   MFH:          2020Q2 (build blanket)
>
> Modified:
>   head/sysutils/duplicity/Makefile
>
> Modified: head/sysutils/duplicity/Makefile
> ==============================================================================
> --- head/sysutils/duplicity/Makefile    Mon Apr  6 00:17:34 2020        (r530849)
> +++ head/sysutils/duplicity/Makefile    Mon Apr  6 00:27:15 2020        (r530850)
> @@ -65,7 +65,7 @@ post-patch:
>  .endfor
>
>  post-patch-NLS-off:
> -       @${REINPLACE_CMD} -e '55,63d' \
> +       @${REINPLACE_CMD} -e '105,129d' \
>                 ${WRKSRC}/setup.py

Thanks for fixing that, Danilo.

This is probably the prime example of when REINPLACE_CMD is the wrong
tool for the job. The command succeeds, even if it breaks the entire
build. This is probably better done as a patch.

I mention this to highlight an ongoing problem that we're trying to
sort out, not to suggest that it's your responsibility to fix it.

# Adam


-- 
Adam Weinberger
adamw at adamw.org
https://www.adamw.org