svn commit: r518243 - head/x11-toolkits/qt5-gui

[Alexey Dokuchaev]

On Sat, Nov 23, 2019 at 04:30:45PM +0100, Adriaan de Groot wrote:
> On Saturday, November 23, 2019 3:55:24 PM CET Alexey Dokuchaev wrote:
> > > +RUN_DEPENDS=   xdg-open:devel/xdg-utils \
> > > +               ${LOCALBASE}/include/vulkan/vulkan.h:devel/vulkan-headers
> > 
> > Commit log does not really explain how come a *header file* is needed
> > at runtime.  If the problem is with `sysutils/qt5-qtdiag', shouldn't it
> > be fixed instead?
> 
> Every consumer of qt5-gui would (potentially) need a BUILD_DEPENDS on
> vulkan headers. This seemed easier. Possibly RUN_DEPENDS is a bad choice;
> I'd put this in LIB_DEPENDS except that it's a headers-only dependency.

I see; this makes it indeed an unusual, but perhaps legit edge case.
Thanks for explanation Adriaan.

> > Also, previously when Vulkan headers were only a bdep I didn't raise
> > the question about why it was not made OPTIONal, but I do now.  There
> > are plenty of Qt5 users who would likely never want to have any Vulkan
> > bits on their systems.
> 
> Since this is a headers-only dependency which is only a few kB in size,
> we (kde@) decided to just install it rather than mess around with trying
> to make it OPTIONAL.

Oh well, fair enough; I guess I can live with that as long as there is
a general agreement to keep Vulkan (that is, substantial dependencies
thereof) optional.

./danfe