svn commit: r516987 - in head: net/remotebox net/remotebox/files x11/gcb x11/gcb/files

[Mateusz Piotrowski]

Hi,

On 11/7/19 9:24 PM, Max Brazhnikov wrote:
> On Thu, 7 Nov 2019 17:07:25 +0000 (UTC) Mateusz Piotrowski wrote:
>> Author: 0mp
>> Date: Thu Nov  7 17:07:24 2019
>> New Revision: 516987
>> URL: https://svnweb.freebsd.org/changeset/ports/516987
>>
>> Log:
>>    Remove suffix from Icon key in desktop entries
>>    
>>    Suffixes, like .png, are not part of the specification. Although many
>>    ports like misc/xfce4-appfinder have implemented workarounds for it,
>>    ports like x11/rofi are missing icons due to a suffix being present in the
>>    Icon key.
>>    
>>    References:
>>    - https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html
>>    - https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#icon_lookup
>>    
>>    Approved by:	portmgr (blanket, runtime fixes)
>>
>> Modified:
>>    head/net/remotebox/Makefile
>>    head/net/remotebox/files/remotebox.desktop
>>    head/x11/gcb/Makefile
>>    head/x11/gcb/files/gcb.desktop
(Snipped.)
> These files look simple. I think they can be removed and replaced with DESKTOP_ENTRIES.

Nice idea! I've done that for net/remotebox in r517851. I am not 
touching x11/gcb at the moment because it was broken the last time I 
checked.

Cheers,

Mateusz