svn commit: r516900 - in head/multimedia: ffms2 vapoursynth vapoursynth-l-smash-works

[Mathieu Arnold]

On Thu, Nov 07, 2019 at 05:06:46PM +0100, Jan Beich wrote:
> Mathieu Arnold <mat at FreeBSD.org> writes:
> 
> > On Thu, Nov 07, 2019 at 12:42:13PM +0100, Jan Beich wrote:
> >
> >> Mathieu Arnold <mat at FreeBSD.org> writes:
> >> 
> >> > On Wed, Nov 06, 2019 at 04:42:28PM +0000, Jan Beich wrote:
> >> >
> >> >> Author: jbeich
> >> >> Date: Wed Nov  6 16:42:28 2019
> >> >> New Revision: 516900
> >> >> URL: https://svnweb.freebsd.org/changeset/ports/516900
> >> >> 
> >> >> Log:
> >> >>   multimedia/vapoursynth: mark BROKEN on non-x86
> >> >> 
> >> >> Modified:
> >> >>   head/multimedia/ffms2/Makefile   (contents, props changed)
> >> >>   head/multimedia/vapoursynth-l-smash-works/Makefile   (contents, props changed)
> >> >>   head/multimedia/vapoursynth/Makefile   (contents, props changed)
> >> >> 
> >> >> Modified: head/multimedia/ffms2/Makefile
> >> >> ==============================================================================
> >> >> --- head/multimedia/ffms2/Makefile	Wed Nov  6 16:42:19 2019	(r516899)
> >> >> +++ head/multimedia/ffms2/Makefile	Wed Nov  6 16:42:28 2019	(r516900)
> >> >> @@ -11,18 +11,24 @@ COMMENT=	FFmpeg-based source library and VapourSynth p
> >> >>  LICENSE=	MIT
> >> >>  LICENSE_FILE=	${WRKSRC}/COPYING
> >> >>  
> >> >> +.if ${MACHINE_ARCH} == amd64 || ${MACHINE_ARCH} == i386
> >> >
> >> > We never use MACHINE_ARCH in the ports tree, we use ARCH, and it is only
> >> > available after an include.  All our tools use/set ARCH, so, please use
> >> > it.
> >> 
> >> This is a temporary workaround, so avoiding "svn blame" churn is preferred.
> >> Also, I planned to switch ARCH to use MACHINE_ARCH internally in bug 215401.
> >
> > Whatever the reason, MACHINE_ARCH must never be used for tests, please
> > fix it to use ARCH. 
> 
> Can you provide a non-cargo-cult rationale? A number of ports (ignoring
> those in question) already use MACHINE_ARCH.

I just had a look, there are, right now, 10 ports that go against our
policy of NEVER USING MACHINE_ARCH FOR TESTS.  So, while 10 is a number,
it is not a rule, it is an exception, something that was missed upon
review.  The rationale is that it is our policy, and as much as I
dislike portlint, it has been sayinc so correctly for the past 15 years.

You do not use MACHINE_ARCH directly, you use ARCH.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20191107/b5758bc3/attachment.sig>