svn commit: r502236 - in head/x11-wm/hikari: . files

[Mateusz Piotrowski]

On Wed, 22 May 2019 at 12:22, Mateusz Piotrowski <0mp at freebsd.org> wrote:

>
>
> On Wed, 22 May 2019 at 09:44, Alexey Dokuchaev <danfe at freebsd.org> wrote:
>
>> On Tue, May 21, 2019 at 09:24:02PM +0000, Mateusz Piotrowski wrote:
>> > New Revision: 502236
>> > URL: https://svnweb.freebsd.org/changeset/ports/502236
>> >
>> > Log:
>> >   Add hikari.desktop for display/login managers.
>> >
>> > +SUB_FILES=   hikari.desktop
>> > +SUB_LIST=    COMMENT="${COMMENT}"
>> >  PLIST_FILES= bin/hikari \
>> > -             man/man1/hikari.1.gz
>> > +             man/man1/hikari.1.gz \
>> > +             share/xsessions/hikari.desktop
>> >
>> > Added: head/x11-wm/hikari/files/hikari.desktop.in
>> >
>> ==============================================================================
>> > @@ -0,0 +1,7 @@
>> > +# $FreeBSD$
>> > +[Desktop Entry]
>> > +Name=hikari
>> > +Comment=%%COMMENT%%
>> > +TryExec=hikari
>> > +Exec=hikari
>> > +Type=Application
>>
>> Why so damn complicated?  What's wrong with DESKTOP_ENTRIES?
>>
>
> I was considering DESKTOP_ENTRIES but it looked like it's only suitable for
> applications, not window managers.
>
> I took a second look and as fair as I understand I can in fact use
> DESKTOP_ENTRIES. I just have to change DESKTOPDIR to
> ${PREFIX}/share/xsessions.
>

I am not sure what to put into Categories. This is another reason
why I decided to go for a custom desktop file.