svn commit: r502238 - in head/x11: . py-pyscreenshot

Kubilay Kocak koobs at FreeBSD.org
Wed May 22 13:04:28 UTC 2019


On 22/05/2019 10:07 pm, Steve Wills wrote:
> Hi,
> 
> On 5/22/19 3:16 AM, Kubilay Kocak wrote:
>> pyscreenshots setup.py doesn't reference pillow, but a dependent port 
> 
> pyscreenshot/plugins/wxscreen.py looks like it does:
> 
> from PIL import Image
> 
> which I think comes from graphics/py-pillow. Am I missing something?

In that case nope, upstream should list pillow in install_requires, 
unless its optional, in which case extras_require

>> for which this was added (pyvirtualdisplay) does. I'm guessing it was 
>> inadvertent.
>>
>> I've already send Steve an email mentioning it
> 
> This is the only email I saw.
> 
>> Either way, not adding a port because the pkg-descr was wrong (I dont 
>> think it is however, given it doesn't depend on pillow) is a bit much.
>>
>> We'd just amend the pkg-descr not to make the claim thereby restoring 
>> balance to your force
> 
> Any suggestions on what pkg-descr should say?

Probably something like from upstreams setup.pylong_description (README):

The pyscreenshot module can be used to copy the contents of the screen 
to a PIL_ or Pillow_ image memory using various back-ends.

Features:
* Cross-platform wrapper
* Capturing the whole desktop
* Capturing an area
* saving to PIL_ or Pillow_ image memory


> Steve



More information about the svn-ports-all mailing list