svn commit: r502238 - in head/x11: . py-pyscreenshot

[Kubilay Kocak]

On 22/05/2019 5:09 pm, Alexey Dokuchaev wrote:
> On Wed, May 22, 2019 at 01:08:43AM +0000, Steve Wills wrote:
>> New Revision: 502238
>> URL: https://svnweb.freebsd.org/changeset/ports/502238
>>
>> Log:
>>    x11/py-pyscreenshot: create port
>>    
>>    Pyscreenshot tries to allow to take screenshots without installing
>>    3rd party libraries.
> 
> O'rly, no 3rd party libs?
> 
>> ...
>> +RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}easyprocess>0:devel/py-easyprocess@${PY_FLAVOR} \
>> +		${PYTHON_PKGNAMEPREFIX}pillow>0:graphics/py-pillow@${PY_FLAVOR} \
>> +		import:graphics/ImageMagick6
> 
> Right, it would pull the whole ImageMagick on you instead.  This port is
> misguiding users and should probably not be added to the collection.  Any
> hand-written bindings around x11/imlib2 would fit the description better.
> 
> ./danfe
> 

pyscreenshots setup.py doesn't reference pillow, but a dependent port 
for which this was added (pyvirtualdisplay) does. I'm guessing it was 
inadvertent.

I've already send Steve an email mentioning it

Either way, not adding a port because the pkg-descr was wrong (I dont 
think it is however, given it doesn't depend on pillow) is a bit much.

We'd just amend the pkg-descr not to make the claim thereby restoring 
balance to your force