svn commit: r495723 - branches/2019Q1/www/node

[Bradley T. Hughes]

Howdy!

On 2019-03-16 13:11, Jochen Neumeister wrote:
> 
> On 16.03.19 05:56, Jan Beich wrote:
>> Mark Felder<feld at FreeBSD.org>  writes:
>>
>>> Author: feld
>>> Date: Thu Mar 14 17:28:11 2019
>>> New Revision: 495723
>>> URL:https://svnweb.freebsd.org/changeset/ports/495723
>>>
>>> Log:
>>>    MFH: r494851 r495525
>>>    
>>>    www/node: Update 11.10.1 -> 11.11.0
>>>    
>>>    https://nodejs.org/en/blog/release/v11.11.0/
>> Is ports-secteam@ actually watching /quarterly?
>>
>> http://beefy2.nyi.freebsd.org/data/120amd64-quarterly/495680/logs/errors/node-11.10.1.log  (before)
>> http://beefy2.nyi.freebsd.org/data/120amd64-quarterly/495844/logs/errors/node-11.11.0.log  (after)
>>
>> www/node bustage blocks www/firefox which already confused some users e.g.,
> 
> ../src/node_os.cc:63:12: error: use of undeclared identifier 'UV_MAXHOSTNAMESIZE'
>    char buf[UV_MAXHOSTNAMESIZE];
>             ^
> ../src/node_os.cc:100:3: error: unknown type name 'uv_utsname_t'
>    uv_utsname_t info;
>    ^
> 2 errors generated.

Yes, I know about this. I am waiting for the thumbs up from 
ports-secteam or portmgr to MFH two devel/libuv changes to fix the build 
breakages.

> I will mark it broken in 2019Q1.
> 
> /cc bhughes: I see you commit today 11.12.0.
> 
> Can you check it, is this update fix this error in 2019Q1?

It will not fix the error. Node.js's minimum version requirement on 
devel/libuv is 1.26.0, but quarterly has 1.24.1. As I mentioned above, I 
am waiting for approval to MFH devel/libuv update to fix the quarterly 
build.

-- 
Bradley T. Hughes
bhughes at freebsd.org