svn commit: r495583 - in head: mail/thunderbird/files www/cliqz/files www/firefox-esr/files www/firefox/files

[Jan Beich]

Tobias Kortkamp <tobik at freebsd.org> writes:

> On Wed, Mar 13, 2019 at 03:41:17PM +0000, Jan Beich wrote:
>
>> Author: jbeich
>> Date: Wed Mar 13 15:41:17 2019
>> New Revision: 495583
>> URL: https://svnweb.freebsd.org/changeset/ports/495583
>> 
>> Log:
>>   www/firefox: unbreak on armv6/armv7/powerpc64
>>   
>>   error: Could not compile `libc`.
>>   warning: build failed, waiting for other jobs to finish...
>>   error[E0433]: failed to resolve: use of undeclared type or module `mem`
>>     --> third_party/rust/libc/src/unix/bsd/freebsdlike/freebsd/powerpc64.rs:35:32
>>      |
>>   35 | pub const _ALIGNBYTES: usize = mem::size_of::<::c_long>() - 1;
>>      |                                ^^^ use of undeclared type or module `mem`
>>   
>>   Reported by:	pkg-fallout
>> 
>> Modified:
>>   head/mail/thunderbird/files/patch-bug1530098   (contents, props changed)
>>   head/www/cliqz/files/patch-bug1530098   (contents, props changed)
>>   head/www/firefox-esr/files/patch-bug1530098   (contents, props changed)
>>   head/www/firefox/files/patch-bug1530098   (contents, props changed)
>> 
>> Modified: head/mail/thunderbird/files/patch-bug1530098
>> ==============================================================================
>> --- head/mail/thunderbird/files/patch-bug1530098	Wed Mar 13 15:28:07 2019	(r495582)
>> +++ head/mail/thunderbird/files/patch-bug1530098	Wed Mar 13 15:41:17 2019	(r495583)
>> @@ -10,7 +10,7 @@ index 587d7582bc89..7cdb11ee2d6b 100644
>>  @@ -1 +1 @@
>> [snip giant cargo-checksum.json diff]
>
> Do you think it might be possible to disable vendor checksums in
> Gecko ports like lang/rust or graphics/librsvg2-rust do to not have
> ~15000 column lines for .cargo-checksum.json in patches?

Self-contained patches are easy to reason about, easy prune on update,
easy to cherry-pick into other ports, easy to bisect in case of
regressions by building outside of ports.

Permanetly disabling vendor checksums only makes sense when patches are
not inteded to be upstreamed e.g., when swapping out bundled libs with
system dependencies.

For one, in ~6.4 MiB large patch to restore --enable-rust-simd dropping
.cargo-checksum.json would only shave ~9% of its size.