svn commit: r495325 - in head: . converters converters/pdf2djvu converters/pdf2djvu/files

[Mathieu Arnold]

On Wed, Mar 13, 2019 at 12:55:05AM +0900, Koichiro Iwao wrote:
> On Tue, Mar 12, 2019 at 03:44:38PM +0100, Mathieu Arnold wrote:
> > On Tue, Mar 12, 2019 at 11:39:34PM +0900, Koichiro Iwao wrote:
> > > On Tue, Mar 12, 2019 at 03:26:49PM +0100, Mathieu Arnold wrote:
> > > > On Mon, Mar 11, 2019 at 02:32:04AM +0000, Koichiro Iwao wrote:
> > > > > +USE_GITHUB=	yes
> > > > > +GH_TUPLE=	jwilk:${PORTNAME}:${PORTVERSION}
> > > > 
> > > > GH_ACCOUNT= jwilk
> > > 
> > > Yes, but what?
> > > 
> > > $ make -C /usr/ports/converters/pdf2djvu -VGH_ACCOUNT
> > > jwilk
> > 
> > I was merely pointing out that what you wrote was bad and the correct
> > way to express what you had meant.
> 
> You like beating around the bush.

Well, there is a simple, and correct, way to do what you want to do, it
is to set:

GH_ACCOUNT=	jwilk

And there is the complicated way you used. The way you used will make
other people looking at the Makefile wonder why you did it that way, if
there was a reason to set GH_TUPLE to a complex value instead of siply
GH_ACCOUNT, like some strange bug that you wanted to get around but
forgot to mention in the commit message.

If you do not with to get post-commit review of your changes so that we
all get a simpler and easier to deal with ports tree, please say so.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20190312/513300b1/attachment.sig>