svn commit: r494447 - in head/textproc/rubygem-nokogiri: . files

[Matthias Fechner]

Am 02.03.2019 um 19:59 schrieb Po-Chuan Hsieh:
> Please read ext/nokogiri/extconf.rb or check ports tree history.
>
> As I mentioned in the commit log, we do not need
> mini_portile/mini_portile2.
> It is used to download and build the libraries (libxml2, libxslt,
> zlib) which is already handled by our ports framework very well.
> Furthermore, it is not needed when using system libraries
> (CONFIGURE_ARGS=--use-system-libraries) [1][2].
>
> Reference:
> [1] https://github.com/sparklemotion/nokogiri/blob/v1.10.1/ext/nokogiri/extconf.rb#L447-L471
> [2]
> https://nokogiri.org/tutorials/installing_nokogiri.html#install-with-system-libraries

Thanks a lot for your answer and explanation!

I'm not really in favor of removing dependency of a port if they are
documented as required.
I understand that is this case you are absolutely sure, that removing
the dependency does not break anything.

But I had in the past the problem that one dependency was missing for a
gem used by gitlab-ce.
Gitlace-ce was running, but it failed on some place. It was a nightmare
to debug this and I do not want to repeat this.
I do not really see, why it is a problem if one port more is installed
with the gem.

If you want to keep the gem patched out of rubygem-nokogiri I suggest to
add a comment in the port to make clear the dep is not missing but was
removed for a good reason.
That will make it much more simple to not forget it in future. ;)

Gruß
Matthias

-- 

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the universe trying to
produce bigger and better idiots. So far, the universe is winning." --
Rich Cook


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20190303/ab63ce88/attachment.sig>