svn commit: r504812 - in head/www/cliqz: . files

[Santhosh Raju]

Apologies for the delayed reply, I was caught up in a busy week, my
replies are in-line.

On Fri, Jun 21, 2019 at 4:35 PM Jan Beich <jbeich at freebsd.org> wrote:
>
> Philip Paeps <philip at FreeBSD.org> writes:
>
> > Author: philip
> > Date: Fri Jun 21 20:10:36 2019
> > New Revision: 504812
> > URL: https://svnweb.freebsd.org/changeset/ports/504812
> >
> > Log:
> >   www/cliqz: update to 1.27.3
> >
> >   PR:         238410
> >   Submitted by:       Santhosh Raju <santhosh.raju at gmail.com> (maintainer)
> [...]
> >  MAKE_ENV+=   LLVM_CONFIG=llvm-config${LLVM_DEFAULT}
> > +MAKE_ENV+=   LLVM_OBJDUMP=${LOCALBASE}/llvm${LLVM_DEFAULT}/bin/llvm-objdump
>
> Both LLVM_CONFIG and LLVM_OBJDUMP can be dropped in favor of CC/CXX e.g.,
>
>   MAKE_ENV+=    CC=clang${LLVM_DEFAULT} CXX=clang++${LLVM_DEFAULT}
>

I tried making this change in www/cliqz but it would not pick up the LLVM_CONFIG

Looking at Mk/bsd.gecko.mk I do see that there is a variable exported

MOZ_EXPORT+=    LLVM_CONFIG=llvm-config${LLVM_DEFAULT}

which does similar functionality to www/cliqz (since cliqz is also
Firefox based).

> as LLVM_CONFIG will be replaced by --with-libclang-path in future,
> see https://bugzilla.mozilla.org/show_bug.cgi?id=1526857

I looked around with the above flag, but was not able to successfully
set it for making www/cliqz compile.

I also tried setting the CC / CXX outside of the MAKE_ENV, and was met
with the same issue, each time in the configure phase it would fail to
find the LLVM configuration.

Let me know if I am doing something wrong from my end.

As of now I shall submit the cliqz-1.27.4 patch without these improvements.

Regards
Santhosh