svn commit: r505045 - head/sysutils/plasma5-ksysguard

[Baptiste Daroussin]

On Mon, Jun 24, 2019 at 06:10:56PM +0000, Piotr Kubaj wrote:
> Author: pkubaj
> Date: Mon Jun 24 18:10:55 2019
> New Revision: 505045
> URL: https://svnweb.freebsd.org/changeset/ports/505045
> 
> Log:
>   sysutils/plasma5-ksysguard: fix build with GCC-based architectures
>   
>   Link with libinotify explicitly to fix linking on GCC architectures.
>   
>   PR:		238702
>   Approved by:	tcberner (maintainer, mentor)
> 
> Modified:
>   head/sysutils/plasma5-ksysguard/Makefile
> 
> Modified: head/sysutils/plasma5-ksysguard/Makefile
> ==============================================================================
> --- head/sysutils/plasma5-ksysguard/Makefile	Mon Jun 24 18:07:12 2019	(r505044)
> +++ head/sysutils/plasma5-ksysguard/Makefile	Mon Jun 24 18:10:55 2019	(r505045)
> @@ -23,5 +23,6 @@ OPTIONS_SUB=	yes
>  
>  INOTIFY_DESC=		Filesystem alteration notifications using inotify
>  INOTIFY_LIB_DEPENDS=	libinotify.so:devel/libinotify
> +INOTIFY_LDFLAGS=	-linotify
>  
>  .include <bsd.port.mk>
> 
At least do provide a -L path to search for the libinotify, note that if this
works on gcc it is only because localbase is automatically added to the search
of when using gcc from ports. (or a USES=localbase)
 
if this option is working correctly with clang based architecture it is probably
that the build system already append -linotify at the right place, meaning the
analysis that led to this fix is wrong and now binary produced by the port is
linked to libinotify while maybe a some of them only needs that.

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20190625/9209c3db/attachment.sig>