svn commit: r504998 - head/sysutils/daggy

Mathieu Arnold mat at FreeBSD.org
Mon Jun 24 18:37:16 UTC 2019


On Sun, Jun 23, 2019 at 07:22:55PM -0700, Yuri wrote:
> On 2019-06-23 18:55, Eugene Grosbein wrote:
> > > build
> > Yes, it's obvious that you added compiler:c++17-lang.
> > It's not obvious what problem does it solve (if it does) and this commit log record
> > would be right place to describe it:-)
> > 
> > 
> 
> I thought that this was also obvious.
> 
> When compilation flags contain the c++17 requirement, gcc-based systems
> usually break, and this serves to prevent this.

In a commit message, what is important is why things are done, the what
is obvious and can be seen by looking at the diff, the why is lost if
not recorded in there.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20190624/96be722a/attachment.sig>


More information about the svn-ports-all mailing list