svn commit: r504800 - in head/cad: . kicad-doc

[Alexey Dokuchaev]

On Fri, Jun 21, 2019 at 11:28:00PM +0200, Christoph Moench-Tegeder wrote:
> ## Alexey Dokuchaev (danfe at freebsd.org):
> ...
> > > +NO_ARCH=	yes
> > 
> > This knob should appear earlier.
> 
> Where? I can't find it anywhere in "Order of Variables" (Ch. 15 of
> the Porter's Handbook), so I was putting it at the end, as in "The
> Rest of the Variables") and portlint didn't complain. And looking
> at other ports, the situation is... not clear.

Typically, a port's Makefile logic roughly corresponds to how people
build and package a piece of software: they first learn about it, then
downlod it, then patch, then build, then package, then install.  Ergo,
it's naturally layed out like this:

<general info about the software: PORTNAME/PORTVERSION/CATEGORIES/...>

<MAINTAINER, COMMENT, and LICENSE>

<*_DEPENDS lines>

<sometimes, GitHub-related knobs go here, separated from the USES
 because it's more fetch-related rather then build-related like the
 other USE_* knobs, but this is largely a personal preference>

<various generic build-related knobs: USES, USE_*, *_CONFIGURE, WRKSRC,
 NO_BUILD, *_TARGET, etc.; sometimes they are split into subgroups for
 readability, e.g. CC/CXXFLAGS, MAKE_ENV/ARGS are often go together>

<package-related knobs: INFO, PLIST_FILES, PORTDOCS, PORTEXAMPLES>

<OPTIONS block + their helpers>

<targets (recipes)>

.include <bsd.port.mk>

So by that logic, I'd place NO_ARCH higher in the Makefile, around with
other generic build-related knobs.

./danfe