svn commit: r504198 - head/Mk
Gerald Pfeifer
gerald at pfeifer.com
Sat Jun 15 09:14:22 UTC 2019
On Sat, 15 Jun 2019, Piotr Kubaj wrote:
> In my opinion, there are not many ports that have USE_GCC=any specified.
True, it's only 58 for USE_GCC=any versus 112 for USE_GCC=yes.
Still 58 ports that won't be tested with the compiler they are
(trying to be) built with on powerpc64.
> Most ports just need USES=compiler:*.
Yes, and that's where we should take action as well.
For example, Mk/Uses/compiler.mk has
.if ${_COMPILER_ARGS:Mopenmp}
.if ${COMPILER_TYPE} == clang
USE_GCC= yes
CHOSEN_COMPILER_TYPE= gcc
.endif
.endif
which means that anyone asking for compiler:openmp gets GCC 4.2,
unless I'm missing something.
Calling that a disservice is a euphemism.
Plus r504153 that jwb@ had to make to biology/ncbi-blast+ as a follow-up
to his recent update is a perfect example of the disservice that using GCC
4.2 by default on powerpc64 provides to its users:
# Force newer GCC on platforms using GCC 4.2 as base
.if ${CHOSEN_COMPILER_TYPE} == gcc
USE_GCC= yes
.endif
This confirms my point that USE_GCC=any or what is practically
equivalent in compiler.mk should be converted to USE_GCC=yes.
Better for our users, better for our maintainers, and more
consistency across platforms.
Gerald
More information about the svn-ports-all
mailing list