svn commit: r506108 - head/graphics/nomacs/files
Tobias C. Berner
tcberner at FreeBSD.org
Sun Jul 7 08:05:47 UTC 2019
Author: tcberner
Date: Sun Jul 7 08:05:46 2019
New Revision: 506108
URL: https://svnweb.freebsd.org/changeset/ports/506108
Log:
graphics/nomacs: fix logic
Added:
head/graphics/nomacs/files/patch-src_DkCore_DkPluginManager.cpp (contents, props changed)
Added: head/graphics/nomacs/files/patch-src_DkCore_DkPluginManager.cpp
==============================================================================
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ head/graphics/nomacs/files/patch-src_DkCore_DkPluginManager.cpp Sun Jul 7 08:05:46 2019 (r506108)
@@ -0,0 +1,19 @@
+/wrkdirs/usr/ports/graphics/nomacs/work/nomacs-3.6.1/ImageLounge/src/DkCore/DkPluginManager.cpp:371:13: warning: '&&' within '||' [-Wlogical-op-parentheses]
+ else if (p && p->interfaceType() == DkPluginInterface::interface_basic || p->interfaceType() == DkPluginInterface::interface_batch) {
+ ~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
+/wrkdirs/usr/ports/graphics/nomacs/work/nomacs-3.6.1/ImageLounge/src/DkCore/DkPluginManager.cpp:371:13: note: place parentheses around the '&&' expression to silence this warning
+ else if (p && p->interfaceType() == DkPluginInterface::interface_basic || p->interfaceType() == DkPluginInterface::interface_batch) {
+ ^
+ ( )
+
+--- src/DkCore/DkPluginManager.cpp.orig 2019-07-07 07:04:23 UTC
++++ src/DkCore/DkPluginManager.cpp
+@@ -368,7 +368,7 @@ void DkPluginContainer::run() {
+ connect(vPlugin->getViewPort(), SIGNAL(showToolbar(QToolBar*, bool)), vPlugin->getMainWindow(), SLOT(showToolbar(QToolBar*, bool)));
+ emit runPlugin(vPlugin, false);
+ }
+- else if (p && p->interfaceType() == DkPluginInterface::interface_basic || p->interfaceType() == DkPluginInterface::interface_batch) {
++ else if (p && (p->interfaceType() == DkPluginInterface::interface_basic || p->interfaceType() == DkPluginInterface::interface_batch)) {
+
+ QAction* a = qobject_cast<QAction*>(QObject::sender());
+
More information about the svn-ports-all
mailing list