svn commit: r494049 - in head/devel/imake: . files

[Cy Schubert]

Making unrelated changes in the same commit, even when documented, makes parsing of the patch necessary for those who might need to analyze a patch months after the fact. Though painful either way, this is more critical in src than ports.



On February 27, 2019 5:12:42 AM PST, Alexey Dokuchaev <danfe at freebsd.org> wrote:
>On Wed, Feb 27, 2019 at 12:55:18PM +0000, Niclas Zeising wrote:
>> New Revision: 494049
>> URL: https://svnweb.freebsd.org/changeset/ports/494049
>> 
>> Log:
>>   devel/imake Add LICENSE
>
>Could your please not include unrealated changes in the same commit?
>Now you've broken svn blaming on these patches, as the real history
>would be masked with this "add LICENSE" nonsense which has nothing
>to do with them.
>
>./danfe
>
>> Modified: head/devel/imake/files/patch-imake.c
>>
>==============================================================================
>> --- head/devel/imake/files/patch-imake.c	Wed Feb 27 12:06:57
>2019	(r494048)
>> +++ head/devel/imake/files/patch-imake.c	Wed Feb 27 12:55:18
>2019	(r494049)
>> @@ -1,6 +1,6 @@
>> ---- imake.c.orig	2013-07-23 06:53:04.000000000 +0200
>> -+++ imake.c	2013-08-31 14:57:48.000000000 +0200
>> -@@ -531,6 +531,14 @@
>> +--- imake.c.orig	2013-08-17 10:11:50 UTC
>> ++++ imake.c
>> +@@ -531,6 +531,14 @@ init(void)
>>   				AddCppArg(p);
>>   			}
>>   	}
>> @@ -15,7 +15,7 @@
>>   	if ((p = getenv("IMAKECPP")))
>>   		cpp = p;
>>   	if ((p = getenv("IMAKEMAKE")))
>> -@@ -1142,29 +1150,17 @@
>> +@@ -1142,29 +1150,17 @@ get_binary_format(FILE *inFile)
>>     int mib[2];
>>     size_t len;
>>     int osrel = 0;
>> 
>> Modified: head/devel/imake/files/patch-imakemdep.h
>>
>==============================================================================
>> --- head/devel/imake/files/patch-imakemdep.h	Wed Feb 27 12:06:57
>2019	(r494048)
>> +++ head/devel/imake/files/patch-imakemdep.h	Wed Feb 27 12:55:18
>2019	(r494049)
>> @@ -1,6 +1,6 @@
>> ---- ./imakemdep.h.orig	2012-03-08 06:47:32.000000000 +0100
>> -+++ ./imakemdep.h	2013-06-12 20:22:52.058999526 +0200
>> -@@ -380,7 +383,7 @@
>> +--- imakemdep.h.orig	2013-08-17 10:11:06 UTC
>> ++++ imakemdep.h
>> +@@ -365,7 +365,7 @@ const char *cpp_argv[ARGUMENTS] = {
>>       defined(__GNUC__) || defined(__GLIBC__)
>>   #    ifdef __i386__
>>   	"-D__i386__",
>> 

-- 
Pardon the typos and autocorrect, small keyboard in use.
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX: <cy at FreeBSD.org> Web: http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.