svn commit: r493407 - head/graphics/xpdf4

[Cy Schubert]

In message <20190220065247.GA77183 at urd.tobik.me>, Tobias Kortkamp 
writes:
> 
>
> --BXVAT5kNtrzKuDFl
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> On Wed, Feb 20, 2019 at 05:37:58PM +1100, Kubilay Kocak wrote:
> > On 20/02/2019 5:34 pm, Tobias Kortkamp wrote:
> > > On Wed, Feb 20, 2019 at 06:14:57AM +0000, Cy Schubert wrote:
> > >> Author: cy
> > >> Date: Wed Feb 20 06:14:57 2019
> > >> New Revision: 493407
> > >> URL: https://svnweb.freebsd.org/changeset/ports/493407
> > >>
> > >> Log:
> > >>    Remove whitespace in USE_QT, otherwise qmake_build is ignored.
> > >>   =20
> > >>    Reported by:	Paul Beard <paulbeard at gmail.com>
> > >>
> > >> Modified:
> > >>    head/graphics/xpdf4/Makefile
> > >>
> > >> Modified: head/graphics/xpdf4/Makefile
> > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D
> > >> --- head/graphics/xpdf4/Makefile	Wed Feb 20 04:50:53 2019	(r49340
> 6)
> > >> +++ head/graphics/xpdf4/Makefile	Wed Feb 20 06:14:57 2019	(r49340
> 7)
> > >> @@ -27,8 +27,7 @@ SUB_FILES=3D	xpdf-man.conf
> > >>  =20
> > >>   USES=3D		compiler:c++11-lang cmake localbase:ldflags \
> > >>   		desktop-file-utils qt:5
> > >> -USE_QT=3D		buildtools_build,concurrent,core,gui,network,pr
> intsupport,\
> > >> -		qmake_build,svg,widgets
> > >> +USE_QT=3D		buildtools_build,concurrent,core,gui,network,pr
> intsupport,=
> qmake_build,svg,widgets
> > >=20
> > > Next step: Replace the , with spaces to actually add Qt dependencies
> > > to the port.  Check with build-depends-list, run-depends-list,
> > > stage-qa.  Currently the port has no Qt 5 dependencies and it fails
> > > to build in Poudriere:
> > >=20
> > > =3D=3D=3D> Checking for items in pkg-plist which are not in STAGEDIR
> > > Error: Missing: libexec/xpdf/xpdf
> > > Error: Missing: %%DATADIR%%/man/man1/xpdf.1.gz
> > > =3D=3D=3D> Error: Plist issues found.
> > >=20
> >=20
> > If USE_* values are never comma-separated (always space separated),=20
> > sounds like a good portlint check to have.
>
> Wouldn't it be much nicer if the framework would consistently check
> them on its own and refuse to proceed with the build if there are
> unknown components in a USE_*?
>
> > If we have some comma-separated support framework bits (I didn't check),=
> =20
> > maybe we should standardize on not doing so
>
> USES=3Dqt already complains about components that it does not recognize.
> I'm surprised that it accepts a comma-separated list silently.

A greater mystery is why 4.00 built in the first place.

I'll need to run this through my poudriere servers after they've 
finished their -current testing.

As to why check-orphans succeeds while poudriere fails still needs to 
be determined.


-- 
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX:  <cy at FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.