svn commit: r519189 - in head/archivers/amigadepacker: . files

Alexey Dokuchaev danfe at freebsd.org
Sat Dec 7 09:05:58 UTC 2019


On Sat, Dec 07, 2019 at 08:30:15AM +0000, Emanuel Haupt wrote:
> New Revision: 519189
> URL: https://svnweb.freebsd.org/changeset/ports/519189
> 
> Log:
>   Per section 4.4.3 of the Porters Handbook, REINPLACE_CMD (sed) should
>   not be used to replace static content.
>   
>   Switch from sed to patch.

IMHO changing existing ports in this way would cause way too much of the
repochurn; not too mention that the rule itself is quote dubious as sed(1)
often allows for more readable and shorter code.  I think this should be
left at committer's and/or maintainer's discretion.

./danfe


More information about the svn-ports-all mailing list