svn commit: r499685 - head/java/openjdk8

Greg Lewis glewis at eyesbeyond.com
Wed Apr 24 14:21:51 UTC 2019


On Tue, Apr 23, 2019 at 06:58:37PM +0200, Mathieu Arnold wrote:
> On Tue, Apr 23, 2019 at 09:27:25AM -0700, Greg Lewis wrote:
> > On Tue, Apr 23, 2019 at 09:46:22AM +0200, Mathieu Arnold wrote:
> > > On Mon, Apr 22, 2019 at 08:52:52PM +0000, Greg Lewis wrote:
> > > > Author: glewis
> > > > Date: Mon Apr 22 20:52:52 2019
> > > > New Revision: 499685
> > > > URL: https://svnweb.freebsd.org/changeset/ports/499685
> > > > 
> > > > Log:
> > > >   Always depend on fontconfig
> > > >   
> > > >   PR:		203862
> > > >   Submitted by:	Dominik Lisiak <dominik.lisiak at bemsoft.pl>
> > > 
> > > You need to bump PORTREVISION when you change the runtime dependencies.
> > 
> > I didn't bump it since this is a build fix.  I.e., we fail the configure
> > step without the dependency.  If that still requires a PORTREVISION bump
> > then I think the porters handbook could use with some clarification on
> > the topic.
> 
> Then it does not, but nothing in the commit message could give any hint
> that it was fixing the build, and not simply registering a dependency
> correctly. 

That's fair.  I didn't pull in the context from the PR to the commit
message.  Will try to do so in future.

-- Greg


More information about the svn-ports-all mailing list