svn commit: r481915 - in head/sysutils/ipmitool: . files

[Mathieu Arnold]

On Fri, Oct 12, 2018 at 02:55:38PM -0600, Sean Bruno wrote:
> 
> 
> On 10/12/18 2:10 PM, Mathieu Arnold wrote:
> > So, you want us to add something like "if the variable EXTRA_PATCHES is
> > already set before, instead of using =, use +="?
> > 
> > I don't really see it happening, we are not going to state all the
> > possible cases, the porter's handbook would end up being ISO9001 and 50k
> > pages long, we assume that you know make(1), so that when you add a
> > variable, you actually look for it in the Makefile to see if it is not
> > already set.
> 
> I don't think I'm asking for that.
> 
> I think I'm asking for "we should have the example be a += instead of a
> =" because of the DOCS variable and how it behaves.  EXTRA_PATCHES
> wasn't in use in this example before I added the openssl1.1.1 patch
> abomination, but I guess, DOCS implicitly means its always in use.

The example is GENERIC.  THIS port has a DOCS option that sets
EXTRA_PATCHES.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20181012/e366401c/attachment.sig>