svn commit: r481915 - in head/sysutils/ipmitool: . files

[Mathieu Arnold]

On Fri, Oct 12, 2018 at 12:05:34PM -0600, Sean Bruno wrote:
> 
> 
> 
> 
> >  
> >> +.include <bsd.port.options.mk>
> >> +
> >> +.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1200085
> >> +EXTRA_PATCHES=	${PATCHDIR}/extra-patch-
> >> src_plugins_lanplus_lanplus__crypt__impl.c
> >> +.endif
> >> +
> > 
> > When the port is built with DOCS=off EXTRA_PATCHES has
> > already been set earlier.  This is overwriting it.  You must
> > use EXTRA_PATCHES+= here.
> > 
> > 
> 
> 
> Can you do me a favor and submit or commit an update to the porter's
> handbook for this?  Its what I used to generate this diff.

So, you want us to add something like "if the variable EXTRA_PATCHES is
already set before, instead of using =, use +="?

I don't really see it happening, we are not going to state all the
possible cases, the porter's handbook would end up being ISO9001 and 50k
pages long, we assume that you know make(1), so that when you add a
variable, you actually look for it in the Makefile to see if it is not
already set.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20181012/64cdbe9d/attachment.sig>