svn commit: r470725 - in head/textproc/tkdiff: . files

[Mathieu Arnold]

On Thu, May 24, 2018 at 12:43:57PM +0200, Tobias C. Berner wrote:
> That was what I suggested initially.
> 
> But as you commented on the target used to install the file without also
> weighing in on the issue of adding binaries, I assumed it was fine :)

I cannot see everything, and most of the times, when my focus catches on
a big mistake, like the two targets, it usually means the Makefile has
larger structural problems that needs addressed first, so I do not delve
too much on what goes on.  When the Makefile looks saner, and a quick
glance cannot find anything blatantly wrong, I look deeper into things.
But in any way, I am human, and I miss stuff.

> mfg Tobias
> 
> On 24 May 2018 at 08:55, Mathieu Arnold <mat at freebsd.org> wrote:
> 
> > On Thu, May 24, 2018 at 06:25:37AM +0000, Tobias Kortkamp wrote:
> > > 2. print/jabref, misc/mc, editors/openoffice-devel, etc. seem to have
> > >    binary files in files/*.png. Can we add new ones or is it forbidden
> > now?
> > >    It seems weird to have to base64 encode icons and decode them during
> > the
> > >    build.
> >
> > I think it would be better to keep binary files out of the ports tree.
> > It's probably as easy to drop them in LOCAL/user, either individually or
> > in an archive.
> >
> > --
> > Mathieu Arnold
> >

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180524/0309a2c4/attachment.sig>