svn commit: r469355 - head/sysutils/UEFITool

[Tobias Kortkamp]

On Tue, May 8, 2018, at 07:19, Yuri Victorovich wrote:
> Author: yuri
> Date: Tue May  8 05:19:03 2018
> New Revision: 469355
> URL: https://svnweb.freebsd.org/changeset/ports/469355
> 
> Log:
>   sysutils/UEFITool: Update 45 -> 49
>   
>   Port changes:
>   * Change to DISTVERSION
>   * Add LICENSE_FILE
>   * Order USExx section
>   * Other small ordering changes
>   * Silence the stripping command
>   
>   PR:		228040
>   Submitted by:	Piotr Kubaj <pkubaj at anongoth.pl> (maintainer; only a 
> version change)
> 
> Modified:
>   head/sysutils/UEFITool/Makefile
>   head/sysutils/UEFITool/distinfo
> 
> Modified: head/sysutils/UEFITool/Makefile
> ==============================================================================
> --- head/sysutils/UEFITool/Makefile	Tue May  8 05:07:47 2018	(r469354)
> +++ head/sysutils/UEFITool/Makefile	Tue May  8 05:19:03 2018	(r469355)
> @@ -2,28 +2,28 @@
>  # $FreeBSD$
>  
>  PORTNAME=	UEFITool
> -PORTVERSION=	45
>  DISTVERSIONPREFIX=	A
> +DISTVERSION=	49
>  CATEGORIES=	sysutils
>  
>  MAINTAINER=	pkubaj at anongoth.pl
>  COMMENT=	UEFI images parser
>  
>  LICENSE=	MIT
> +LICENSE_FILE=	${WRKSRC}/../LICENSE.md
>  
> +USES=		qmake:outsource
>  USE_GITHUB=	yes
>  GH_ACCOUNT=	LongSoft
> +USE_GL=		gl
> +USE_QT5=	core gui widgets buildtools_build qmake_build
>  
> -WRKSRC_SUBDIR=		${PORTNAME}
> +WRKSRC_SUBDIR=	${PORTNAME}
>  
>  PLIST_FILES=	bin/${PORTNAME}
>  
> -USES=		qmake:outsource
> -USE_GL=		gl
> -USE_QT5=	buildtools_build core gui widgets qmake_build
> -
>  pre-install:
> -	${STRIP_CMD} ${WRKDIR}/.build/${PORTNAME}
> +	@${STRIP_CMD} ${WRKDIR}/.build/${PORTNAME}
>  
>  do-install:
>  	${INSTALL_PROGRAM} ${WRKDIR}/.build/${PORTNAME} ${STAGEDIR}${PREFIX}/bin

What's the point of STRIP_CMD followed by INSTALL_PROGRAM
(which will strip the binary as well)?  I think pre-install can be completely
dropped.