svn commit: r469188 - head/ports-mgmt/pkg_replace

[Baptiste Daroussin]

On Sun, May 06, 2018 at 10:50:12AM +0000, Alexey Dokuchaev wrote:
> On Sun, May 06, 2018 at 12:34:20PM +0200, Kurt Jaeger wrote:
> > > On Sun, May 06, 2018 at 10:15:03AM +0000, Koichiro Iwao wrote:
> > > > New Revision: 469188
> > > > URL: https://svnweb.freebsd.org/changeset/ports/469188
> > > > 
> > > > Log:
> > > >   ports-mgmt/pkg_replace: Update to 20180424
> > > >   
> > > >   - Cleanup code
> > > >   - Speed up and strictly check package's dependencies
> > > >   - While here, pet portlint by using pkg-plist instead of PLIST_FILES
> > > 
> > > Could you explain what did you achieve by moving three-line PLIST_FILES
> > > into pkg-plist?  How can "pet portlint" be a reason for a change while
> > > we generally encourage converting <6-line pkg-plist's into PLIST_FILES?
> > 
> > There was a problem if the pkg-list stayed in PLIST_FILES
> > (the build in poudriere failed with a signal 6 in make package).
> > 
> > Koichiro is working to reproduce/report this, until then...
> 
> *facepalm*.  This poudriere-driven development is more and more disturbing.
> You didn't attempt to understand the problem, you didn't attempt to fix the
> PLIST_FILES (remove bogus %%ETCDIR%% since this is Makefile), you didn't
> ask for a peer review.  meta@ pessimized the port, provided wrong commit
> log (it tells *nothing* about poudriere failing with a signal 6 in make
> package, it says "pet portlint"), and you've approved it like there's
> nothing wrong with all of this. :-(

If you read it carefully this is not a "poudriere-driven development". as it
shows a real bug happening to anyone running make package...

And most of the poudriere-driven development as you call them which are
disturbing are in fact real bugs in the ports, and nothing poudriere only.

The only things that may annoy you are bugs in the ports that are appearing only
when not in a clean environment (so no reproducible in poudriere)  which is no
t the case here.

Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180506/29ca4bd2/attachment-0001.sig>