svn commit: r465830 - head/astro/stellarium

[Mathieu Arnold]

On Wed, Mar 28, 2018 at 06:58:41PM +0000, Alexey Dokuchaev wrote:
> On Wed, Mar 28, 2018 at 08:06:46PM +0200, Mathieu Arnold wrote:
> > On Wed, Mar 28, 2018 at 05:24:37PM +0000, Alexey Dokuchaev wrote:
> > > On Wed, Mar 28, 2018 at 05:20:48PM +0000, Alexey Dokuchaev wrote:
> > > > New Revision: 465830
> > > > URL: https://svnweb.freebsd.org/changeset/ports/465830
> > > > 
> > > > Log:
> > > >   - Update `astro/stellarium' to version 0.18.0
> > > >   - TIMESTAMP (Stellarium-stellarium-v0.17.0_GH0.tar.gz) = 1521967282
> > >                                         ^^^^^^
> > > Ah, sorry, I've fucked up, it should read 0.18.0.  TIMESTAMP logic should
> > > really be fixed so we won't have to reiterate it in the commit logs. :-(
> > 
> > It was decided that the TIMESTAMP logic would work as it currently does,
> > so these lines you add to your commit messages are really not needed.
> 
> Current logic is both confusing and redundant, as it adds yet another
> timestamp to already existing distfile(s) timestamp and commit timestamp.
> 
> Per my understanding, it was only put in place because of Git, which does
> not support keyword expansion.  Personally I don't understand why would we
> want to support a crippled VCS, but before I figure a way out of this, I
> feel that proper TIMESTAMP metainfo should either go to commit message, or
> be recorded elsewhere.

It needs to be VCS and filesystem independant, we do not want to rely on
outside metadata. The timestamp needs to be stored in some file, the
distinfo file was considered the best solution.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180328/2e07c626/attachment.sig>