svn commit: r463618 - head/sysutils/htop

[Sunpoet Po-Chuan Hsieh]

On Tue, Mar 6, 2018 at 2:11 AM, Yuri <yuri at freebsd.org> wrote:

> On 03/05/18 08:57, Sunpoet Po-Chuan Hsieh wrote:
>
>
> scripts/MakeHeader.py is no-op in fact.
> It is used to generate header files but all header files are all ready in
> the tarball.
> I've run the script manually with python 3.6 and the generated header
> files are identical with the ones from the tarball.
>
> USES=shebangfix is also unnecessary because scripts/MakeHeader.py is
> unused.
>
>
> I saw this, and decided to keep USES=shebangfix. The reason was that
> MakeHeader.py file is only not run because all .h files are newer than .c
> files. If you will touch any .c file after extract, MakeHeader.py will be
> run. So it depends on timestamps, which is arbitrary and might change with
> the next release, making it error-prone.
>

Even though, python:2.7 is incorrect. That script works with python 3.6.


> I asked them to fix this: https://github.com/hishamhm/htop/issues/754
>
> This port can be built without USES=localbase.
>
> For some reason, it fails for me without USES=localbase. It can't find
> ncurses.h
>
That looks strange. We have ncurses.h in base system.

> Again, I asked them to fix it: https://github.com/hishamhm/htop/issues/755
>
>
> Yuri
>