svn commit: r475418 - head/science/xcrysden

[Eugene Grosbein]

27.07.2018 15:50, Yuri Victorovich wrote:

> Author: yuri
> Date: Fri Jul 27 08:50:41 2018
> New Revision: 475418
> URL: https://svnweb.freebsd.org/changeset/ports/475418
> 
> Log:
>   science/xcrysden: Add missing runtime dependencies
> 
> Modified:
>   head/science/xcrysden/Makefile
> 
> Modified: head/science/xcrysden/Makefile
> ==============================================================================
> --- head/science/xcrysden/Makefile	Fri Jul 27 08:04:49 2018	(r475417)
> +++ head/science/xcrysden/Makefile	Fri Jul 27 08:50:41 2018	(r475418)
> @@ -2,6 +2,7 @@
>  
>  PORTNAME=	xcrysden
>  DISTVERSION=	1.5.60
> +PORTREVISION=	1
>  CATEGORIES=	science
>  MASTER_SITES=	http://www.xcrysden.org/download/
>  
> @@ -12,7 +13,11 @@ LICENSE=	GPLv2
>  LICENSE_FILE=	${WRKSRC}/COPYING
>  
>  LIB_DEPENDS=	libfftw3.so:math/fftw3
> -RUN_DEPENDS=	bwidget>0:x11-toolkits/bwidget
> +RUN_DEPENDS=	bwidget>0:x11-toolkits/bwidget \
> +		babel:science/openbabel \
> +		convert:graphics/ImageMagick \
> +		ppmtompeg:graphics/netpbm \
> +		xwd:x11/xwd
>  
>  USES=		fortran gmake localbase:ldflags tcl tk
>  USE_GL=		gl glu
> 

If you are doing this just because "make" in port directory reports allegedly missing run-time dependencies,
please stop adding them.

It misgudes you showing recursive dependencies and recursive dependencies should never be added to leaf port
but to intermidiate port considering possible conditional builds, options etc. This should be done with care,
including needed minimal version numbers according to requirements documented upstream.