svn commit: r460016 - head/devel/shflags

Alexey Dokuchaev danfe at FreeBSD.org
Fri Jan 26 18:18:39 UTC 2018


On Fri, Jan 26, 2018 at 06:10:52PM +0000, Sunpoet Po-Chuan Hsieh wrote:
> New Revision: 460016
> URL: https://svnweb.freebsd.org/changeset/ports/460016
> 
> Log:
>   Update to 1.2.3
>   
>   - Update pkg-descr
>   - Take maintainership
>   
> [...]
>  
> -USE_GITHUB=	yes
> -GH_ACCOUNT=	kward
> -
>  NO_ARCH=	yes
>  NO_BUILD=	yes
>  
>  PLIST_FILES=	lib/shflags
>  
> +GH_ACCOUNT=	kward
> +USE_GITHUB=	yes

Why did you move GitHub-related knobs (fetch-related) from their normal
location all the way down (below packaging-related PLIST_FILES) and also
missorted them?

>  do-install:
> -	${INSTALL_DATA} ${WRKSRC}/shflags ${STAGEDIR}${PREFIX}/lib
> +	${INSTALL_DATA} ${WRKSRC}/shflags ${STAGEDIR}${PREFIX}/lib/

Useless, gratuitous change.  Please don't do that.

./danfe


More information about the svn-ports-all mailing list