svn commit: r459676 - in head/sysutils/zfsnap: . files

[Mathieu Arnold]

On Mon, Jan 22, 2018 at 09:09:10PM +0000, Eugene Grosbein wrote:
> 23.01.2018 2:25, Mathieu Arnold wrote:
> 
> > On Mon, Jan 22, 2018 at 06:31:59PM +0000, Eugene Grosbein wrote:
> >> 23.01.2018 0:26, Mathieu Arnold wrote:
> >>
> >>> On Mon, Jan 22, 2018 at 05:05:49PM +0000, Eugene Grosbein wrote:
> >>>>   Move creation of files from "do-patch" to "post-extract" target,
> >>>>   so that patches from files/ directory get applied.
> >>>>   
> >>>> -do-patch:
> >>>> +post-extract:
> >>>
> >>> I am sure you meant to use post-extract here.
> >>
> >> And I did. What is a problem here?
> > 
> > Sorry, meant post-patch here.
> 
> "post-patch" means we will not be able conditionally patch generated files with extra-patches, for example.
> As we could not apply simple patch before this change due to abuse of "do-patch".
> So, "post-extract" is intentional.

post-extract is for extracting more files, or copying files in WRKSRC.
Patching must be done in a *-patch target, be it pre-patch or post-patch.
Of course you can use makepatch, if the patches does not touch files you
change in post-patch, you can run makepatch without thinking about it.
If you do also change those files, you can run:
make extract do-patch makepatch

So, please, use post-patch.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180122/f016845c/attachment.sig>