svn commit: r458926 - head/java/java-checkstyle

Alexey Dokuchaev danfe at FreeBSD.org
Sun Jan 14 16:45:52 UTC 2018


On Sat, Jan 13, 2018 at 11:25:40AM +0000, Muhammad Moinur Rahman wrote:
> New Revision: 458926
> URL: https://svnweb.freebsd.org/changeset/ports/458926
> 
> Log:
>   java/java-checkstyle: Update version 7.6=>8.7
>   
>   - Pet PORTLINT
> 
> Added:
>   head/java/java-checkstyle/pkg-plist   (contents, props changed)
> 
> Modified: head/java/java-checkstyle/Makefile
> ...
> @@ -21,8 +21,6 @@ WRKSRC=		${WRKDIR}/${PORTNAME}-${PORTVERSION}
>  
>  JAR_FILE=	${PORTNAME}-${PORTVERSION}-all.jar
>  
> -PLIST_FILES=	bin/${PORTNAME} \
> -		%%JAVAJARDIR%%/${PORTNAME}.jar
> 
> Added: head/java/java-checkstyle/pkg-plist
> ...
> @@ -0,0 +1,2 @@
> +bin/checkstyle
> +%%JAVAJARDIR%%/checkstyle.jar

I don't get it: we typically use PLIST_FILES for short PLISTs, why not
simply fix (expand) %%JAVAJARDIR%% and retain PLIST_FILES instead of
creating two-line pkg-plist?

./danfe


More information about the svn-ports-all mailing list