svn commit: r458000 - head/www/nginx

[Cy Schubert]

The reason is people can set their own poudriere options. For instance, if I enabled a module in my poudriere, I need it rebuilt when it is updated. Otherwise we work from a paradigm of only support for default options built on the FreeBSD cluster. It is illogical to think otherwise.

POERTREVISION bump is required and expected.

---
Sent using a tiny phone keyboard.
Apologies for any typos and autocorrect.
Also, this old phone only supports top post. Apologies.

Cy Schubert
<Cy.Schubert at cschubert.com> or <cy at freebsd.org>
The need of the many outweighs the greed of the few.
---

-----Original Message-----
From: Adam Weinberger
Sent: 06/01/2018 07:15
To: Sergey A. Osokin
Cc: Mathieu Arnold; v at fatpipi.com; Jochen Neumeister; ports-committers at freebsd.org; svn-ports-all at freebsd.org; svn-ports-head at freebsd.org
Subject: Re: svn commit: r458000 - head/www/nginx

> On 6 Jan, 2018, at 6:41, Sergey A. Osokin <osa at FreeBSD.org> wrote:
>
> On Thu, Jan 04, 2018 at 08:30:55AM +0100, Mathieu Arnold wrote:
>> Le 04/01/2018 ?? 02:56, Vanilla Hsu a ??crit :
>>> auth-digest  is not default module, so you don't need to bump
>>> PORTREVISION.
>>
>> Yes you do.
>> To quote
>> https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html#makefile-portrevision
>> :
>>
>> PORTREVISION must be increased each time a change is made to the
>> port that changes the generated package in any way. That includes
>> changes that only affect a package built with non-default options.
>
> I've tried to find a commit in doc area to better understand who and why
> did this change.  Another question is why this so important change
> hasn't been discussed and why committers and community haven't been  
> notified
> about that in advance.

Hi Sergey,

It's been policy for a long time now, a number of years at least. It does  
feel strange at first, but it really does benefit our users in the end. The  
reason we have to bump PORTREVISION for non-default options is the same  
reason we have to bump PORTREVISION for default options. When something  
changes, build scripts need to know to rebuild the package. There is simply  
no way for that to happen unless we tell them to.

I know you're not a fan of forcing default option users to rebuild ports  
when their setup hasn't changed, but the other side of it is that we often  
force non-default option users to rebuild when THEIR setup hasn't changed.  
It works both ways, and it's just a consequence of our build paradigm. It  
has to happen though, every time.

# Adam


--
Adam Weinberger
adamw at adamw.org
http://www.adamw.org